[OE-core] [PATCHv2 2/3] u-boot: make FILESDIR a shared setting.

Richard Purdie richard.purdie at linuxfoundation.org
Mon Jul 2 19:03:35 UTC 2012


On Mon, 2012-07-02 at 13:42 -0300, Otavio Salvador wrote:
> On Mon, Jul 2, 2012 at 10:33 AM, Chris Larson <clarson at kergoth.com> wrote:
> > On Mon, Jul 2, 2012 at 4:24 AM, Otavio Salvador <otavio at ossystems.com.br> wrote:
> >> On Mon, Jul 2, 2012 at 2:44 AM, Paul Gortmaker
> >> <paul.gortmaker at windriver.com> wrote:
> >>> The setting is the same in all recipes, so move it to
> >>> the shared settings in u-boot.inc
> >>>
> >>> Signed-off-by: Paul Gortmaker <paul.gortmaker at windriver.com>
> >>
> >> Acked-by: Otavio Salvador <otavio at ossystems.com.br>
> >
> > It shouldn't be using the old, legacy FILESDIR mechanism at all.
> 
> Indeed; grepping for it shows nothing.
> 
> This can be removed :-D

This isn't what Chris meant. BitBake handles FILESDIR, not the metadata
(and grepping bitbake will show a result).

I'm tempted to take the patch on the grounds that a single reference to
fix is probably easier than several other references. The replacement is
probably something like:

FILESPATH =. "${FILE_DIRNAME}/u-boot-git/${MACHINE}:"

We should really get on, replace the remaining references and complete
removal of FILESDIR.

Cheers,

Richard








More information about the Openembedded-core mailing list