[OE-core] [PATCH] libgomp: add libgomp (openmp) library, and build for powerpc targets by default

[McClintock Matthew-B29882]

On Fri, Jul 6, 2012 at 11:05 AM, Khem Raj <raj.khem at gmail.com> wrote:
> On Fri, Jul 6, 2012 at 7:26 AM, McClintock Matthew-B29882
> <B29882 at freescale.com> wrote:
>> On Fri, Jul 6, 2012 at 1:13 AM, Khem Raj <raj.khem at gmail.com> wrote:
>>> On Thu, Jul 5, 2012 at 10:36 PM, McClintock Matthew-B29882
>>> <B29882 at freescale.com> wrote:
>>>> On Fri, Jul 6, 2012 at 12:25 AM, Khem Raj <raj.khem at gmail.com> wrote:
>>>>> On Thu, Jul 5, 2012 at 9:32 PM, Matthew McClintock <msm at freescale.com> wrote:
>>>>>> Signed-off-by: Matthew McClintock <msm at freescale.com>
>>>>>> ---
>>>>>>  meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>>>>>>  meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>>>>>>  meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>>>>>>  3 files changed, 12 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>>> index 020e21b..32545eb 100644
>>>>>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>>> @@ -1,6 +1,6 @@
>>>>>>  require gcc-common.inc
>>>>>>
>>>>>> -PR = "r25"
>>>>>> +PR = "r26"
>>>>>>
>>>>>>  # Third digit in PV should be incremented after a minor release
>>>>>>  # happens from this branch on gcc e.g. currently its 4.6.0
>>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>>> index 34bfaeb..a7d478c 100644
>>>>>> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>>> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>>> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>>>>>>      --with-build-sysroot=${STAGING_DIR_TARGET}"
>>>>>>
>>>>>>  RUNTIMETARGET = "libssp libstdc++-v3"
>>>>>> +RUNTIMETARGET_append_powerpc = " libgomp"
>>>>>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>>>>>  #  ?
>>>>>>  # libiberty
>>>>>>  # libmudflap
>>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>>> index feb8735..001a444 100644
>>>>>> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>>> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>>> @@ -13,6 +13,8 @@ PACKAGES = "\
>>>>>>    libgfortran-dev \
>>>>>>    libmudflap \
>>>>>>    libmudflap-dev \
>>>>>> +  libgomp \
>>>>>> +  libgomp-dev \
>>>>>>  "
>>>>>>  # The base package doesn't exist, so we clear the recommends.
>>>>>>  RRECOMMENDS_${PN}-dbg = ""
>>>>>> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>>>>>>    ${libdir}/libmudflap*.a \
>>>>>>    ${libdir}/libmudflap*.la"
>>>>>>
>>>>>> +FILES_libgomp = "${libdir}/libgomp*.so.*"
>>>>>> +FILES_libgomp-dev = "\
>>>>>> +  ${libdir}/libgomp*.so \
>>>>>> +  ${libdir}/libgomp*.a \
>>>>>> +  ${libdir}/libgomp*.la \
>>>>>> +  ${libdir}/libgomp.spec \
>>>>>> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>>>>>
>>>>> Did you build a non ppc architecture to verify that it does not
>>>>> complain about empty packages ?
>>>>
>>>> I tested without the powerpc overrides first...
>>>
>>> OK let me put it differently remove
>>>
>>> +RUNTIMETARGET_append_powerpc = " libgomp"
>>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>>
>>> and leave the rest of patch in
>>>
>>> then build for powerpc
>>
>> That's what I'm saying I did... I did not even get libgomp packages
>> (rpm's) in this scenario....
>
> OK, Dont you get warnings about empty packages.

Let me double check.... it does not seem to have any such messages:

$ bitbake -c cleanall gcc-runtime
$ bitbake gcc-runtime
$ grep libgomp -r tmp/cooker.log.20120706190*

With your changes above starting from scratch with a PR bump for kicks
does not even make the packages.

-M