[OE-core] wanting to clarify patch mechanics

[Robert P. J. Day]

On Sat, 7 Jul 2012, Martin Jansa wrote:

> On Sat, Jul 07, 2012 at 06:04:07AM -0400, Robert P. J. Day wrote:
> >
> >   speaking of apply, it would seem that "apply=yes" is redundant, is
> > that correct?  there are a couple dozen examples of that throughout
> > oe-core, mostly in the bash recipe file.  is there anything subtle
> > about that parameter, or is it truly superfluous?
>
> apply=yes is default for *.patch and .diff, for files with other
> extension it's still needed (e.g. those entries in bash)

  ah, that's useful to know, thanks.

> so there is only a few redundant usages in oe-core:
> meta/recipes-connectivity/portmap/portmap.inc:  file://make.patch;apply=yes"
> meta/recipes-core/eggdbus/eggdbus_0.6.bb:          file://gtk-doc.patch;apply=yes \
> meta/recipes-core/eggdbus/eggdbus_0.6.bb:           file://marshal.patch;apply=yes \
> meta/recipes-graphics/libxsettings-client/libxsettings-client_0.10.bb:        file://link-x11.patch;apply=yes \
> meta/recipes-graphics/xorg-proto/calibrateproto_git.bb:           file://fix.patch;apply=yes"
> meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:SRC_URI_append_poky = " file://owl-menu.patch;apply=yes "
> meta/recipes-sato/pimlico/contacts.inc:SRC_URI_append_poky = " file://contacts-owl-window-menu.patch;apply=yes "
> meta/recipes-sato/pimlico/dates.inc:SRC_URI_append_poky = " file://dates-owl-window-menu.patch;apply=yes "
> meta/recipes-sato/settings-daemon/settings-daemon_git.bb:           file://addsoundkeys.patch;apply=yes \
> meta/recipes-support/libcroco/libcroco_0.6.3.bb:SRC_URI_append = " file://croco.patch;apply=yes \
>
> some devs cleanup those when doing upgrades.. if it bothers you enough
> you can send patch removing those...

  it didn't really bother me so much as i just wanted to make sure it
didn't represent something subtle that changed the expected behaviour,
and your earlier explanation clarified that.  i might send a patch
along later.  thanks for the clarification.

  today's going to be a very oe-oriented day so expect more nitpicking
pedantry.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================