[OE-core] tcf-agent, matchbox-wm-2: Correct "proto=git" to "protocol=git".
Richard Purdie
richard.purdie at linuxfoundation.org
Mon Jul 9 17:00:47 UTC 2012
On Mon, 2012-07-09 at 12:27 +0300, Andrei Gherzan wrote:
> On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day
> <rpjday at crashcourse.ca> wrote:
>
> "proto=git" is not a valid parameter for the git fetcher.
>
> NOTE: package matchbox-wm-2-0.1+git1
> +01fa5465743c9ee43d040350f4405d35293e4869-r1: task do_fetch:
> Succeeded
>
> Anyway, in the git.py, code is searching for "protocol" parameter:
> ud.proto = ud.parm['protocol']
>
> ... so your change seems legit.
>
> On another hand, svn.py is using:
> proto = ud.parm.get('proto', 'svn')
>
> A good think would be to use the same parameter names for all
> protocols.
>
I agree but how do we do this without breaking the world? We probably
should try and standardise it, probably to "protocol".
Cheers,
Richard
More information about the Openembedded-core
mailing list