[OE-core] [PATCH] gnupg: ensure deterministic build by disabling libcurl

[Khem Raj]

On Tue, Jul 10, 2012 at 11:26 AM, Saul Wold <sgw at linux.intel.com> wrote:
> On 07/09/2012 06:21 PM, Khem Raj wrote:
>>
>> On Mon, Jul 9, 2012 at 4:45 PM, Saul Wold <sgw at linux.intel.com> wrote:
>>>
>>> On 07/09/2012 03:43 PM, Khem Raj wrote:
>>>>
>>>>
>>>> On Mon, Jul 9, 2012 at 3:04 PM, Saul Wold <sgw at linux.intel.com> wrote:
>>>>>
>>>>>
>>>>> gnupg has it's own fake curl, since we use gnupg with zypper, there
>>>>> does
>>>>> not
>>>>> seem to be a strong reason to add curl to the depends list.
>>>>
>>>>
>>>>
>>>> what does disabling curl has to do with gnupg being used with zypper ?
>>>>
>>> I was looking for where gnupg was used within oe-core and it's usage
>>> model
>>> to see if it made sense to go with the extra dependency for gnupg, let me
>>> know your reasoning.  Generally especially for natives we look for ways
>>> to
>>> reduce the initial build time.
>>
>>
>> I am all for it. I wanted to understand the context thanks for that.
>> On another note
>
> Do you want me to amend the commit message?
>
>
>
>> it would be interesting to know what are we losing if we disable curl
>> or external curl
>>
> gnupg seems to use a very small subset of curl and the curl_shim that it
> provides covers what's need in a very basic manner (including handling proxy
> setups).  I would guess (after a cursory look) that we would lose better
> error handling and performance for the gpgkeys_curl command line interface.
>
> I think that acceptable.
>


yes add good summary of this to commit log would help in future references