[OE-core] [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR

[McClintock Matthew-B29882]

On Sun, Jul 15, 2012 at 6:18 AM, Liu Ting-B28495 <B28495 at freescale.com> wrote:
> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org [mailto:openembedded-core-bounces at lists.openembedded.org] On Behalf Of Richard Purdie
> Sent: Thursday, July 12, 2012 7:03 PM
> To: Patches and discussions about the oe-core layer
> Cc: McClintock Matthew-B29882
> Subject: Re: [OE-core] [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR
>
> On Thu, 2012-07-12 at 04:17 -0500, b28495 at freescale.com wrote:
>> From: Ting Liu <b28495 at freescale.com>
>>
>> Signed-off-by: Ting Liu <b28495 at freescale.com>
>> ---
>>  meta/classes/kernel.bbclass |    7 ++++++-
>>  1 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 81c334b..420a1ec 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -122,7 +122,12 @@ kernel_do_install() {
>>       #
>>       install -d ${D}/${KERNEL_IMAGEDEST}
>>       install -d ${D}/boot
>> -     install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION}
>> +        install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin
>> +        cd ${D}/${KERNEL_IMAGEDEST}/
>> +        rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin
>> +        ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGE_SYMLINK_NAME}.bin
>> +        ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE}
>> +     cd -
>>       install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION}
>>       install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION}
>>       install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION}
>
> This is going to break users who rely on the existing naming/layout.
>
> The patch description is lacking on why we need to do this too, it just says what you're doing and not why.
>
> Cheers,
>
> Richard
>
>
> [Liu Ting-B28495] on our side, we used two ways to load the kernel images. 1) load from Ethernet 2) load from hard disk which deployed with the rootfs image containing kernel image (installing the package 'kernel-image'). We cannot use the same bootargs in u-boot due to the mismatched name.

Ting,

I understand what you said but what does this have to do with u-boot
bootargs? Need a bit more info here. Can you tell us what images are
generated before, and after your patch? And also, update the commit
message with this info?

-M

>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core