[OE-core] any current standard on avoiding use of both "_append" and "+="?

[Robert P. J. Day]

On Mon, 23 Jul 2012, Paul Eggleton wrote:

> On Sunday 22 July 2012 15:12:51 Robert P. J. Day wrote:
> >   quick check shows this:
> >
> > recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I
> > ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> > recipes-sato/webkit/webkit-gtk_1.8.1.bb:EXTRA_OECONF_append_powerpc +=
> > "--with-unicode-backend=glib"
> > recipes-sato/webkit/webkit-gtk_1.8.1.bb:CPPFLAGS_append_powerpc +=
> > "-I${STAGING_INCDIR}/pango-1.0 \
> >
> >   was there going to be any effort to avoid combining "_append" with
> > "+=" in recipe files, simply for the sake of clarity?
>
> It's fine for these to be cleaned up as long as a leading space is added for
> the second and third (since += will be doing this at the moment).

  is this valid?

meta/classes/rootfs_rpm.bbclass:IMAGE_ROOTFS_EXTRA_SPACE_append = "${@base_contains("PACKAGE_INSTALL", "zypper", " + 51200", "" ,d)}"

does one not need the leading space in this context?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================