[OE-core] libxp: Change superfluous "+=" to simple "=" when using _append

Chris Larson clarson at kergoth.com
Thu Jul 26 19:34:12 UTC 2012


On Thu, Jul 26, 2012 at 12:27 PM, Saul Wold <sgw at linux.intel.com> wrote:
> On 07/23/2012 02:59 AM, Robert P. J. Day wrote:
>>
>>
>> Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
>>
>> ---
>>
>> diff --git a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> index 349dad1..dbd4609 100644
>> --- a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> +++ b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>> @@ -15,7 +15,7 @@ PE = "1"
>>
>>   XORG_PN = "libXp"
>>
>> -CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I
>> ${S}/include/X11/extensions"
>> +CFLAGS_append = " -I ${S}/include/X11/XprintUtil -I
>> ${S}/include/X11/extensions"
>>
>>   SRC_URI += "file://fix-cast-error.patch"
>>
>>
> Merged into OE-Core

A second janitorial-type task would be to find and remove unnecessary
uses of _append entirely. This one for example, it's highly unlikely a
+= wouldn't do the job here. :)
-- 
Christopher Larson




More information about the Openembedded-core mailing list