[OE-core] image.bbclass: Update outdated reference to "export IMAGE_BASENAME"

Andrea Adami andrea.adami at gmail.com
Fri Jul 27 12:53:44 UTC 2012


On Fri, Jul 27, 2012 at 2:01 PM, Robert P. J. Day <rpjday at crashcourse.ca>wrote:

> On Fri, 27 Jul 2012, Richard Purdie wrote:
>
> > On Thu, 2012-07-26 at 19:06 -0400, Robert P. J. Day wrote:
> > > Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
> > >
> > > ---
> > >
> > >   does this look about right?
> > >
> > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > > index 1799bf1..b0b476f 100644
> > > --- a/meta/classes/image.bbclass
> > > +++ b/meta/classes/image.bbclass
> > > @@ -58,10 +58,9 @@ PACKAGE_GROUP_dev-pkgs[optional] = "1"
> > >  PACKAGE_GROUP_doc-pkgs = "${@' '.join('%s-doc' % pkg for pkg in
> normal_pkgs_to_install(d))}"
> > >  PACKAGE_GROUP_doc-pkgs[optional] = "1"
> > >
> > > -# "export IMAGE_BASENAME" not supported at this time
> > >  IMAGE_INSTALL ?= ""
> > >  IMAGE_INSTALL[type] = "list"
> > > -IMAGE_BASENAME[export] = "1"
> > > +export IMAGE_BASENAME
> > >  export PACKAGE_INSTALL ?= "${IMAGE_INSTALL}
> ${ROOTFS_BOOTSTRAP_INSTALL} ${FEATURE_INSTALL}"
> > >  PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
> > >
> > > diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bbb/meta/recipes-core/images/
> core-image-minimal-initramfs.bb
> > > index 7f6826c..ddc2142 100644
> > > --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
> > > +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
> > > @@ -8,7 +8,6 @@ IMAGE_INSTALL = "initramfs-live-boot
> initramfs-live-install initramfs-live-insta
> > >  # Do not pollute the initrd image with rootfs features
> > >  IMAGE_FEATURES = ""
> > >
> > > -export IMAGE_BASENAME = "core-image-minimal-initramfs"
> > >  IMAGE_LINGUAS = ""
> >
> > I meant just to remove the export flag here, so:
> >
> > -export IMAGE_BASENAME = "core-image-minimal-initramfs"
> > +IMAGE_BASENAME = "core-image-minimal-initramfs"
>
>   ah, all right, then.
>
> rday
>
> --
>
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                         http://crashcourse.ca
>
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

By the way,

we have followed pedissequally and re-introduced 'export IMAGE_BASENAME'
[1] when we adapted our initramfs image for oe-core,  even though we had
built whitout until then, both in oe-classic and in oe-core. **

Regards

Andrea

[1]
http://cgit.openembedded.org/meta-handheld/commit/?id=3021e1fc380067666a63fa5b2bdfc5fd16282973
**
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120727/7ba90ad9/attachment-0002.html>


More information about the Openembedded-core mailing list