[OE-core] Package recipes change proposal (system-wide) - name wise

Anders Darander anders at chargestorm.se
Sat Jul 28 09:22:33 UTC 2012


On 26 jul 2012, at 22:43, "Joshua Lock" <josh at linux.intel.com> wrote:
> On Thu, 2012-07-26 at 20:40 +0100, Richard Purdie wrote:
>> 
>> Also, as others have mentioned, git can detect move operations if you
>> tell it to.
> 
> FYI the create-pull-request script passes -M40 to git format-patch,
> which tells git to:
> 
> "should consider a delete/add pair to be a rename if more than 40% of
> the file hasn’t changed."
> 
> Though with the size of some recipes perhaps the -M value should be
> increased, or not passed at all?

No, the -M option shouldn't be removed. Why would you like to increase the percentage needed to handle a delete/add pair as a rename? Rather, it could very well be lowered even more, though the current 40% might be a good compromise.

Detecting a delete/add pair as a rename operation with some further modifications of the recipe does make reviewing the upgrade patches a lot easier...

Cheers,
Anders


More information about the Openembedded-core mailing list