[OE-core] [PATCH] kernel.bbclass: Preserve generated headers

[Bruce Ashfield]

On Tue, Jul 31, 2012 at 12:19 PM, Darren Hart <dvhart at linux.intel.com> wrote:
>
>
> On 07/31/2012 08:16 AM, Bruce Ashfield wrote:
>> On Tue, Jul 31, 2012 at 11:10 AM, Khem Raj <raj.khem at gmail.com> wrote:
>>> asm/unistd.h includes asm/unistd_64.h on x86_64
>>> and asm/unistd_32.h on i386 but these files are
>>> generated files in 3.4 and when we do 'make clean' they get
>>> deleted and it shows up as an error when building
>>> external modules. May be its a 3.4 kernel bug may be not
>>> but make clean should have left the tree in
>>> a shape to build modules but it does not.
>>>
>>> Probably we should run make modules_prepare after having
>>> run make clean.
>>>
>>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>>> ---
>>>  meta/classes/kernel.bbclass |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>> index b19ed4c..4ac3d48 100644
>>> --- a/meta/classes/kernel.bbclass
>>> +++ b/meta/classes/kernel.bbclass
>>> @@ -197,6 +197,8 @@ kernel_do_install() {
>>>         if [ -f include/generated/bounds.h ]; then
>>>                 cp include/generated/bounds.h $kerneldir/include/generated/bounds.h
>>>         fi
>>> +       mkdir -p $kerneldir/arch/${ARCH}/include/generated/
>>> +       cp -fR arch/${ARCH}/include/generated/* $kerneldir/arch/${ARCH}/include/generated/
>>
>> If we take the blanket protection, we should be able to drop the
>> bounds.h specific
>> case a the same time .. right ?
>
> No, different dirs (one is ARCH)

Aha. I missed that, but can we back up a directory and take everything from
generated/* ? .. assuming your question about binaries being in those
directory is "no".

Cheers,

Bruce

>
>>
>> I'm ok with this, but I can run a test with 'make modules_prepare'
>> being run if you
>> already haven't.
>
> We really can't, this builds scripts, which we don't want as this
> results in native binaries being installed on the target :(
>
> We need some cross-build-system-friendly make targets for this.
>
>>
>> Cheers,
>>
>> Bruce
>>
>>>
>>>         # Remove the following binaries which cause strip or arch QA errors
>>>         # during do_package for cross-compiled platforms
>>> --
>>> 1.7.5.4
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>>
>
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Technical Lead - Linux Kernel



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"