[OE-core] oddities related to "_append" and "_prepend" in oe-core

[Robert P. J. Day]

  inspired by richard purdie's correction of my original patch, i did
a quick grep to see if i could find any oddities related, first, to
uses of "_append"; specifically, where the string being appended did
*not* start with a blank.  there are certainly proper examples of
that, say when one is appending to a path, or appending to a filename,
and so on where a blank would be *wrong*.

  but there also appear to be "errors", so here's the grep command and
its output:

$ grep -r "_append = \"[^ ]" *
meta/conf/bitbake.conf:DISTRO_FEATURES_append = "${@oe.utils.distro_features_backfill(d)}"
meta/recipes-devtools/gdb/gdb-cross-canadian.inc:EXTRA_OECONF_append = "--with-python=${WORKDIR}/python"
meta/recipes-devtools/prelink/prelink_git.bb:OVERRIDES_append = ":${TARGET_OS_ORIG}"
meta/recipes-devtools/gcc/gcc-cross-intermediate.inc:CROSS_TARGET_SYS_DIR_append = ".${PN}"
meta/recipes-devtools/gcc/gcc-cross-initial.inc:CROSS_TARGET_SYS_DIR_append = ".${PN}"
meta/recipes-core/uclibc/uclibc.inc:FILES_${PN}-dev_append = "\
meta/recipes-core/base-files/base-files_3.0.14.bb:docdir_append = "/${P}"
meta/recipes-core/eglibc/eglibc_2.15.bb:PR_append = "+svnr${SRCPV}"
meta/recipes-core/eglibc/eglibc_2.13.bb:PR_append = "+svnr${SRCPV}"
meta/classes/autotools.bbclass:# EXTRA_OECONF_append = "${@autotools_set_crosscompiling(d)}"
meta/classes/useradd.bbclass:DEPENDS_append = "${USERADDDEPENDS}"
meta/classes/multilib.bbclass:PACKAGEFUNCS_append = "do_package_qa_multilib"
meta/classes/libc-package.bbclass:OVERRIDES_append = ":${TARGET_ARCH}-${TARGET_OS}"
meta/classes/rootfs_rpm.bbclass:IMAGE_ROOTFS_EXTRA_SPACE_append = "${@base_contains("PACKAGE_INSTALL", "zypper", " + 51200", "" ,d)}"
meta/classes/cross-canadian.bbclass:PATH_append = ":${TMPDIR}/sysroots/${HOST_ARCH}/${bindir_cross}"
$

  at the very least, the second line of output above seems incorrect:

meta/recipes-devtools/gdb/gdb-cross-canadian.inc:EXTRA_OECONF_append = "--with-python=${WORKDIR}/python"

that *definitely* looks like it wants a leading blank, no?

  one can do the same with "_prepend" and missing trailing blanks, but
it's not quite as pleasant and i didn't see anything obviously amiss
there.

  thoughts?  longer post on appends and conditional appends coming
shortly.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================