[OE-core] [PATCH] rt-tests: fix dependency on eglibc, clean LDFLAGS passing
Denys Dmytriyenko
denis at denix.org
Tue Mar 20 15:28:46 UTC 2012
On Tue, Mar 20, 2012 at 08:01:44AM -0700, Darren Hart wrote:
>
>
> On 03/19/2012 05:22 PM, Denys Dmytriyenko wrote:
> > From: Denys Dmytriyenko <denys at ti.com>
> >
> > Replace dependency on eglibc with virtual/libc
> > Pass LDFLAGS to TARGET_CC_ARCH, instead of CFLAGS as Makefile overrides it
> >
> > Signed-off-by: Denys Dmytriyenko <denys at ti.com>
>
> Thanks Denys,
>
> Looking through the rt-tests sources I don't see TARGET_CC_ARCH
> anywhere. Have you confirmed that changes made there make their way into
> the actual build?
Darren,
TARGET_CC_ARCH is not an rt-tests specific variable, it's used in OE.
Although, TARGET_LDFLAGS might be more appropriate for this purpose,
historically TARGET_CC_ARCH was heavily used to pass distro LDFLAGS to the
app's build process - grepping it would show many such cases in OE-Core and
especially in meta-oe...
> What was the problem you ran into?
Not a problem per se, but it was not getting all the LDFLAGS being passed,
more specifically:
-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
BTW, in Classic OE it was failing on GNU Hash QA check w/o this.
--
Denys
> > ---
> > meta/recipes-rt/rt-tests/rt-tests_0.83.bb | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-rt/rt-tests/rt-tests_0.83.bb b/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
> > index 6425027..3755c79 100644
> > --- a/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
> > +++ b/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
> > @@ -1,7 +1,7 @@
> > DESCRIPTION = "Real-Time preemption testcases"
> > HOMEPAGE = "https://rt.wiki.kernel.org/index.php/Cyclictest"
> > SECTION = "tests"
> > -DEPENDS = "linux-libc-headers eglibc"
> > +DEPENDS = "linux-libc-headers virtual/libc"
> > LICENSE = "GPLv2 & GPLv2+"
> > LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
> > file://src/cyclictest/cyclictest.c;beginline=7;endline=9;md5=ce162fe491d19d2ec67dff6dbc938d50 \
> > @@ -11,13 +11,13 @@ SRCREV = "5f1e84f8b015df3ff950056494134eca3f640d70"
> >
> > # git -> 0.83 needs a PE bump
> > PE = "1"
> > -PR = "r1"
> > +PR = "r2"
> >
> > SRC_URI = "git://github.com/clrkwllms/rt-tests.git"
> >
> > S = "${WORKDIR}/git"
> >
> > -CFLAGS += "-I${S}/src/include -D_GNU_SOURCE -Wall -Wno-nonnulli ${LDFLAGS}"
> > +TARGET_CC_ARCH += "${LDFLAGS}"
> >
> > # calling 'uname -m' is broken on crossbuilds
> > EXTRA_OEMAKE = "NUMA=0"
>
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
>
More information about the Openembedded-core
mailing list