[OE-core] [PATCH 1/2] libx11-1.4.4: Add patch makekeys_crosscompile.patch

[Paul Menzel]

Am Donnerstag, den 01.03.2012, 14:14 +0800 schrieb Xiaofeng Yan:
> On 2012年02月09日 17:06, Paul Menzel wrote:

> > Am Donnerstag, den 09.02.2012, 16:05 +0800 schrieb Xiaofeng Yan:
> >> From: Xiaofeng Yan<xiaofeng.yan at windriver.com>
> >>
> >> LSB 4.1 complain a host contamination error from libx11 because of absent
> >> patch "makekeys_crosscompile.patch" from libx11-trim-1.4.4.
> >>
> >> [YOCTO #1970]
> > could you squash both patches please?
> >
> > Also please add the output from the cover letter to the commit message.
> >
> >> Signed-off-by: Xiaofeng Yan<xiaofeng.yan at windriver.com>

I just noticed. Your Thunderbird setup seems to be broken. For some
reason it deletes spaces.

> >> ---
> >>   .../libx11-1.4.4/makekeys_crosscompile.patch       |   45 ++++++++++++++++++++
> >>   1 files changed, 45 insertions(+), 0 deletions(-)
> >>   create mode 100644 meta/recipes-graphics/xorg-lib/libx11-1.4.4/makekeys_crosscompile.patch
> >>
> >> diff --git a/meta/recipes-graphics/xorg-lib/libx11-1.4.4/makekeys_crosscompile.patch b/meta/recipes-graphics/xorg-lib/libx11-1.4.4/makekeys_crosscompile.patch

Here Thunderbird removed a line break.

> >> new file mode 100644
> >> index 0000000..e5eacf0
> >> --- /dev/null
> >> +++ b/meta/recipes-graphics/xorg-lib/libx11-1.4.4/makekeys_crosscompile.patch
> >> @@ -0,0 +1,45 @@
> >> +Because the size of "unsigned long" is different between 32-bit
> >> +and 64-bit, judge whether target is 32-bit or 64-bit and tell
> >> +"makekey".
> > Trailing space at the end.
> >
> > Could you also add the error message to the patch file in a *separate*
> > patch please. Preferably before copying it.
>
> Do you mean I use an separated file to record error message?
> So there are two file here. one is for  makekeys_crosscompile.patch, 
> another is for a file to record error message. right?

Sorry, I did not understand your reply either. :/

1. Copy the error message you got when building without the patch.
2. Go to

    meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch

and add that error message to the commit message of the patch above.
Make that the first patch.
3. Now copy this file to libx11-1.4.4 and submit as a second patch.

> >> +
> >> +Upstream-Status: Pending
> >> +
> >> +Signed-off-by: dbuitenh at windriver.com
> >> +
> >> +--- libX11-1.3.4.orig/src/util/makekeys.c	2010-01-15 09:11:36.000000000 +0800
> >> ++++ libX11-1.3.4/src/util/makekeys.c	2011-05-24 19:04:25.454774908 +0800
> > […]


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120301/e48abea2/attachment-0002.sig>