[OE-core] [PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Andreas Müller]

On Fri, Mar 2, 2012 at 1:38 PM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Fri, 2012-03-02 at 13:29 +0100, Andreas Müller wrote:
>> On Thu, Mar 1, 2012 at 4:50 PM, Richard Purdie
>> <richard.purdie at linuxfoundation.org> wrote:
>> > On Wed, 2012-02-29 at 21:33 +0100, Petr Štetiar wrote:
>> >> | ln: failed to create symbolic link `beagleboard/systemd-image-beagleboard.tar.bz2': File exists
>> >> NOTE: package systemd-image-1.0-r0: task do_rootfs: Failed
>> >>
>> >> Signed-off-by: Petr Štetiar <ynezz at true.cz>
>> >> ---
>> >>  meta/classes/image_types.bbclass |    2 +-
>> >>  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > Is this still necessary after the recent image_types.bbclass fixes?
>> >
>> I pulled ~3-4 hours ago and the error persists. I don't know if it is
>> important for this problem but I am using opkg and get:
>>
>> | ln: failed to create symbolic link
>> `/home/andreas/tmp/oe-core-eglibc/deploy/images/overo/xfce-base-image-overo.tar.bz2':
>> File exists
>> NOTE: package xfce-base-image-1.0-r0: task do_rootfs: Failed
>
> Could you see what the IMAGE_FSTYPES variable contains please?
>
> (bitbake xfce-base-image -e | grep ^IMAGE_FSTYPES)
>
> The code shouldn't be trying to create this symlink more than once so
> whilst I understand the intent of the patch adding -f, I'd like to
> understand the root cause of the problem to ensure there isn't some
> other issue.
>
Agreed:

IMAGE_FSTYPES="tar.bz2 tar.bz2"

Seems a 'sum' of local.conf

IMAGE_FSTYPES = "tar.bz2"

and machine.conf

IMAGE_FSTYPES += "tar.bz2"

Andreas