[OE-core] net-tools breaks on rebuild

[Steve Sakoman]

I'm still encountering recipes that fail when sstate hash forces a
rebuild after a pull.

The latest is net-tools in nettools_do_patch:

| ERROR: Function failed: nettools_do_patch (see
/media/Work/yocto/tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/net-tools-1.60-23-r0/temp/log.do_patch.658
for further information)
| patching file debian/compat
| patching file debian/README.source
| patching file debian/rules
| patching file debian/config.h
| patching file debian/config.make
| patching file debian/install
| patching file debian/control
| patching file debian/copyright
| patching file debian/changelog
| patching file debian/watch
| patching file debian/patches/CVS-20081003-config.in_sync.patch
| patching file debian/patches/local-manpages.patch
| patching file debian/patches/CVS-20020730-route.c_opts_64.patch
| patching file debian/patches/CVS-lib_sync.patch
| patching file debian/patches/CVS-20051204-slttach.c_sync.patch
| patching file debian/patches/CVS-20071202-rarp.c_sync.patch
| patching file debian/patches/CVS-20081003-statistics.c_sync.patch
| patching file debian/patches/CVS-20051204-arp.c_sync.patch
| patching file debian/patches/CVS-20081002-ifconfig.c_sync.patch
| patching file debian/patches/CVS-20060927-mii-tool.c_sync.patch
| patching file debian/patches/CVS-20070316-netstat.c_sync.patch
| patching file debian/patches/netstat.c-local_changes.patch
| patching file debian/patches/CVS-20061011-ipmaddr.c_buffer_overflow.patch
| patching file debian/patches/series
| patching file debian/patches/Bug#345331-socket_overflow.patch
| patching file debian/patches/lib_local_changes.patch
| patching file debian/patches/CVS-20061011-includes_sync.patch
| patching file debian/patches/CVS-20031011-hostname.c_sync.patch
| patching file debian/patches/Bug#254243-netstat.c-wide-opt.patch
| patching file debian/patches/CVS-20081002-manpages_sync.patch
| patching file debian/patches/translations.patch
| patching file debian/patches/CVS-20030911-nameif.c_sync.patch
| patching file debian/patches/netstat.c-assorted_changes.patch
| Applying patch
/media/Work/yocto/tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/net-tools-1.60-23-r0/net-tools-1.60/debian/patches/CVS-20020730-route.c_opts_64.patch
| patching file route.c
| Hunk #1 FAILED at 2.
| Hunk #2 FAILED at 142.
| Hunk #3 succeeded at 184 with fuzz 1 (offset 8 lines).
| 2 out of 3 hunks FAILED -- rejects in file route.c
| patching file route.c
| Hunk #1 FAILED at 2.
| Hunk #2 FAILED at 142.
| Hunk #3 succeeded at 192 with fuzz 1 (offset 16 lines).
| 2 out of 3 hunks FAILED -- rejects in file route.c
| patching file route.c
| Hunk #1 FAILED at 2.
| Hunk #2 FAILED at 142.
| Hunk #3 succeeded at 200 with fuzz 1 (offset 24 lines).
| 2 out of 3 hunks FAILED -- rejects in file route.c
| Patch /media/Work/yocto/tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/net-tools-1.60-23-r0/net-tools-1.60/debian/patches/CVS-20020730-route.c_opts_64.patch
does not apply (enforce with -f)
NOTE: package net-tools-1.60-23-r0: task do_patch: Failed
ERROR: Task 1 (/home/sakoman/source/yocto/poky/meta/recipes-extended/net-tools/net-tools_1.60-23.bb,
do_patch) failed with exit code '1'
Waiting for 7 active tasks to finish:

I suspect the issue is in the recipes python do_patch:

# We invoke base do_patch at end, to incorporate any local patch
python do_patch() {
	bb.build.exec_func('nettools_do_patch', d)
	bb.build.exec_func('patch_do_patch', d)
}

Not sure how to fix this, but thought I would document the issue for
those more knowledgeable.

Steve