[OE-core] [PATCH 3/3] buildhistory: remove duplicate entries from dot graph

Koen Kooi koen at dominion.thruhere.net
Tue Mar 20 12:11:38 UTC 2012


Op 20 mrt. 2012, om 12:48 heeft Paul Eggleton het volgende geschreven:

> On Tuesday 20 March 2012 12:00:55 Koen Kooi wrote:
>> There are various conditions that lead to duplicate entries in the dot graph
>> which need to get fixed, but this patch is a catchall.
> 
> Dependencies and recommends are already de-duped - are we getting duplicates 
> in the package list as well?

From what I'm seeing, only dupes in the dot files:

https://github.com/Angstrom-distribution/buildhistory/commit/b2a256e02e04349db51e663e35b2bb9989acc854#diff-1

>> Another benefit is that the sort order is now know, leading to less spurious
>> diffs in buildhistory commits.
> 
> The package list is already sorted, and so are the dependencies and 
> recommends, so how would the sort order be changing?

Those fields are not sorted in the package itself[1], re-running bitbake systemd-image after these changes:

 angstrom_feed_configs -> opkg [style=dotted];
-angstrom_task_boot -> task_boot;
 angstrom_task_boot -> angstrom_version;
+angstrom_task_boot -> task_boot;
[..]
-htop -> ncurses_terminfo;
-htop -> libtinfo5;
 htop -> libncurses5;
-iw -> libnl_genl_3_200;
+htop -> libtinfo5;
+htop -> ncurses_terminfo;
 iw -> libnl_3_200;

I think I know why [2] doesn't work:

koen at dominion:/data/ssd/OE/buildhistory$ echo b c a | sort
b c a
koen at dominion:/data/ssd/OE/buildhistory$ echo -e b\\nc\\na | sort
a
b
c

Let me know how you want me to respin this series, each commit is an RFC on its own.

regards,

Koen

[1] https://github.com/openembedded/oe-core/commit/06b740d4ca077fb4c89ee6d1065fabb02da45ec6
[2] https://github.com/openembedded/oe-core/commit/830df6067c1ea4a5aab580b42ba7e1e84fe1bcbf



More information about the Openembedded-core mailing list