[OE-core] [PATCH] speex: fix FILES variables
Richard Purdie
richard.purdie at linuxfoundation.org
Wed Mar 21 14:01:46 UTC 2012
On Wed, 2012-03-21 at 13:56 +0100, Eric Bénard wrote:
> Le Wed, 21 Mar 2012 12:26:12 +0000,
> Richard Purdie <richard.purdie at linuxfoundation.org> a écrit :
>
> > On Wed, 2012-03-21 at 12:08 +0100, Eric Bénard wrote:
> > > @@ -24,5 +24,4 @@ EXTRA_OECONF = " --enable-fixed-point --with-ogg-libraries=${STAGING_LIBDIR} \
> > >
> > > PACKAGES += "${PN}-bin"
> > > FILES_${PN} = "${libdir}/lib*.so.*"
> > > -FILES_${PN}-dev += "${libdir}/lib*.so.*"
> > > FILES_${PN}-bin = "${bindir}"
> >
> > Doesn't this mean -dev files are ending up in the main package?
> >
> this seems to work fine as this (with no other layer than oe-core).
>
> packages-split/speex
> `-- usr
> `-- lib
> |-- libspeexdsp.so.1 -> libspeexdsp.so.1.5.0
> |-- libspeexdsp.so.1.5.0
> |-- libspeex.so.1 -> libspeex.so.1.5.0
> `-- libspeex.so.1.5.0
>
> 2 directories, 4 files
>
> packages-split/speex-dev/
> .../...
> |-- lib
> | |-- libspeexdsp.la
> | |-- libspeexdsp.so -> libspeexdsp.so.1.5.0
> | |-- libspeex.la
> | |-- libspeex.so -> libspeex.so.1.5.0
> | `-- pkgconfig
> | |-- speexdsp.pc
> | `-- speex.pc
> .../...
>
> > Shouldn't this be:
> >
> > FILES_${PN} = "${libdir}/lib*${SOLIBS}"
> > FILES_${PN}-dev = "${libdir}/lib*${SOLIBSDEV}"
> >
> > or better, remove these and add:
> >
> > inherit lib_package
> >
> > ?
> >
> no clear idea on that, you are the boss to tell me which one you
> prefer ;-)
Well, I think "inherit lib_package" is going to be cleanest. Your
original patch is correct in its own right though, this just gives some
better cleanup :)
Cheers,
Richard
More information about the Openembedded-core
mailing list