[OE-core] [PATCH 2/4] module.bbclass: sync pkg_post{inst, rm} with kernel.bbclass

Koen Kooi koen at dominion.thruhere.net
Fri Mar 23 18:20:16 UTC 2012


Op 23 mrt. 2012, om 18:58 heeft Andreas Oberritter het volgende geschreven:

> On 23.03.2012 18:20, Koen Kooi wrote:
>> 
>> Op 23 mrt. 2012, om 17:37 heeft Andreas Oberritter het volgende geschreven:
>> 
>>> * Run depmod when the rootfs gets generated.
>>> 
>>> Signed-off-by: Andreas Oberritter <obi at opendreambox.org>
>>> ---
>>> meta/classes/module.bbclass |    9 +++++----
>>> 1 files changed, 5 insertions(+), 4 deletions(-)
>>> 
>>> diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass
>>> index 53c16b7..e370b24 100644
>>> --- a/meta/classes/module.bbclass
>>> +++ b/meta/classes/module.bbclass
>>> @@ -37,15 +37,16 @@ module_do_install() {
>>> }
>>> 
>>> pkg_postinst_append () {
>>> -	if [ -n "$D" ]; then
>>> -		exit 1
>>> -	fi
>>> +if [ -n "$D" ]; then
>>> +	${HOST_PREFIX}depmod -A -b $D -F ${STAGING_KERNEL_DIR}/System.map-${KERNEL_VERSION} ${KERNEL_VERSION}
>>> +else
>>> 	depmod -a
>>> 	update-modules || true
>>> +fi
>> 
>> That encodes host system paths into the package, which is not a good thing for tools like narcissus and hob.
> 
> So should we remove the same lines from kernel.bbclass?

I think so, I don't think we want to hand out binaries with scripts that say things like:

foo-linux-depmod -F /storage/openembedded-is-a-poopyhead/something

regards,

Koen



More information about the Openembedded-core mailing list