[OE-core] [oe-core][PATCH 2/2] kernel.bbclass: unify white spaces
Martin Jansa
martin.jansa at gmail.com
Thu Mar 29 12:16:46 UTC 2012
On Thu, Mar 29, 2012 at 11:05:47AM +0100, Richard Purdie wrote:
> On Thu, 2012-03-29 at 08:24 +0200, Martin Jansa wrote:
> > * indentation was with spaces and tabs, unify to use tabs instead of
> > spaces, because "python populate_packages" expects tabs (or 8 spaces)
> > and we're doing populate_packages_preppend here
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > ---
> > meta/classes/kernel.bbclass | 38 +++++++++++++++++++-------------------
> > 1 files changed, 19 insertions(+), 19 deletions(-)
>
> FWIW, we're supposed to be using tabs for shell code and spaces (4) for
> python. Unfortunately populate_package() is special due to the number of
> places we append/prepend it and the need to be consistent with
> whitespace.
>
> I'm therefore not sure it makes sense to re-indent the anonymous python.
Agreed, but that anonymous python used spaces and tabs in the same
function which is ugly.
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120329/e167bc89/attachment-0002.sig>
More information about the Openembedded-core
mailing list