[OE-core] [oe-core][PATCHv 05/10] pixman: add native support and perl-native to DEPENDS from meta-oe

[Richard Purdie]

On Fri, 2012-03-30 at 16:22 +0200, Martin Jansa wrote:
> On Fri, Mar 30, 2012 at 03:10:32PM +0100, Richard Purdie wrote:
> > On Fri, 2012-03-23 at 23:30 +0100, Martin Jansa wrote:
> > > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > > ---
> > >  meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb |    3 ++-
> > >  1 files changed, 2 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb b/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb
> > > index bf239d9..e4e3460 100644
> > > --- a/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb
> > > +++ b/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb
> > > @@ -12,7 +12,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=14096c769ae0cbb5fcb94ec468be11b3 \
> > >                      file://pixman/pixman-matrix.c;endline=25;md5=ba6e8769bfaaee2c41698755af04c4be \
> > >                      file://pixman/pixman-arm-neon-asm.h;endline=24;md5=9a9cc1e51abbf1da58f4d9528ec9d49b \
> > >                     "
> > > -DEPENDS += "zlib libpng"
> > > +DEPENDS += "zlib libpng perl-native"
> > > +BBCLASSEXTEND = "native"
> > 
> > Er, why does this need perl-native? If it really does, the correct way
> > to do this is with "inherit perlnative" and then PATH gets set
> > correctly. I'd prefer not to add that dependency if its not needed
> > though.
> 
> It was added 2 years ago
> http://git.openembedded.org/openembedded/commit/?id=c1993858d847ac17f4bd00655adf5655fd9d2c6c
> 
> and it's still mandatory dep:
> configure.ac:AC_PATH_PROG(PERL, perl, no)
> configure.ac:if test "x$PERL" = xno; then
> configure.ac:    AC_MSG_ERROR([Perl is required to build pixman.])

We do assume plain perl is present on the system we're building on. I'd
imagine that perl is good enough for the purposes of building pixman?

We did use to have race conditions around using the host perl which is
why we now have perlnative.bbclass. I therefore believe the dependency
is unnecessary...

Cheers,

Richard