[OE-core] [PATCH 0/1] kernel-yocto: export GUILT_BASE

[Bruce Ashfield]

On Wed, May 9, 2012 at 4:04 PM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Wed, 2012-05-09 at 09:08 -0400, Bruce Ashfield wrote:
>> On Wed, May 9, 2012 at 8:42 AM, Bruce Ashfield <bruce.ashfield at gmail.com> wrote:
>> > On Wed, May 9, 2012 at 2:51 AM, Richard Purdie
>> > <richard.purdie at linuxfoundation.org> wrote:
>> >> On Tue, 2012-05-08 at 15:23 -0400, Bruce Ashfield wrote:
>> >>> Richard/Saul,
>> >>>
>> >>> As Frans Meulenbroeks noted this morning, guilt wasn't functional
>> >>> in the devshell. The fix was simple enough, and by ensuring that
>> >>> GUILT_BASE is exported, it works without any extra steps now.
>> >>>
>> >>> I wasn't sure if there a better way to call 'up' to the base
>> >>> method, so I repeated the call to oe_terminal in the do_devshell()
>> >>> in kernel-yocto.bbclass.
>> >>>
>> >>> If there's another approach, let me know and I'll respin the patch.
>> >>
>> >> Can't you just set:
>> >>
>> >> GUILT_BASE = "meta"
>> >
>> > Will that export to the subshell ? I didn't try it .. since I didn't
>> > think it would.
>> > I'll give that a go here :)
>>
>> With just that set in kernel-yocto.bbclass, and I launch devshell, I get this:
>>
>> % guilt applied
>> Patches directory doesn't exist, try guilt-init
>>
>> So unless I misunderstood what you are suggesting, I still need that explicit
>> export.
>
> Sorry, let me be more clear. I meant does:
>
> OE_TERMINAL_EXPORTS += "GUILT_BASE"
> GUILT_BASE = "meta"

Aha. Yes. That does work, since the setVar does that same thing :)

I can drop my devshell override and it works. I'll update my patch and push it
back to the branch in the pull request.

Bruce

>
> work?
>
> I'm not sure we need everything in the original patch...
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"