[OE-core] [PATCH] Revert "kmod: Use base_libdir for installing libkmod"
Koen Kooi
koen at dominion.thruhere.net
Fri May 18 10:37:04 UTC 2012
Op 18 mei 2012, om 12:29 heeft Richard Purdie het volgende geschreven:
> On Fri, 2012-05-18 at 09:52 +0200, Koen Kooi wrote:
>> Op 17 mei 2012, om 23:02 heeft Richard Purdie het vo
>> Those QA checks are a joke. I can fix the QA warnings by moving all
>> kmod binaries to $bindir or $sbindir since binaries in /usr/bin
>> and /usr/bin are exempt from the checks. That would break the
>> split /usr case as well. These checks are global as well when they
>> only should apply to recipes needed to get /usr mounted.
>>
>> That's why I consider the current checks misguided and harmfull. As
>> seen from the breakage it allows people to break pkgconfig, which
>> didn't get picked up by QA checks. And then it turns out that you an
>> fix the QA warnings in such a way that it breaks the intent of the
>> warnings.
>
> So we need to improve the QA checks, no argument here.
Would a new, additional check for /lib/pkgconfig/*.pc make sense?
>
>> But this is all a false dillemma, you could have merged Otavio's patch
>> (which I Ack'ed) which supports split /usr and puts the pkgconfig in
>> the right place.
>
> I likely still will but I was worried when he replied saying it still needed more
> testing. I took your reply to the consolidated pull request to refer to
> your patch.
I was indeed very unspecific there, my apologies.
regards,
Koen
More information about the Openembedded-core
mailing list