[OE-core] [PATCH] insane: detect and warn about relocations in .text
Phil Blundell
philb at gnu.org
Tue Nov 6 17:24:13 UTC 2012
Ping?
On Wed, 2012-10-03 at 11:24 +0100, Phil Blundell wrote:
> Signed-off-by: Phil Blundell <pb at pbcl.net>
> ---
> This requires qa.elf.run_objdump() so needs to be applied after the
> patch which adds that function.
>
> meta/classes/insane.bbclass | 26 +++++++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 5848ab4..ff35ed8 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -108,7 +108,7 @@ def package_qa_get_machine_dict():
>
>
> # Currently not being used by default "desktop"
> -WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts staticdev libdir"
> +WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts staticdev libdir textrel"
> ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la perms dep-cmp"
>
> ALL_QA = "${WARN_QA} ${ERROR_QA}"
> @@ -421,6 +421,30 @@ def package_qa_check_desktop(path, name, d, elf, messages):
> for l in output:
> messages.append("Desktop file issue: " + l.strip())
>
> +QAPATHTEST[textrel] = "package_qa_textrel"
> +def package_qa_textrel(path, name, d, elf, messages):
> + """
> + Check if the binary contains relocations in .text
> + """
> +
> + if not elf:
> + return
> +
> + if os.path.islink(path):
> + return
> +
> + phdrs = elf.run_objdump("-p", d)
> + sane = True
> +
> + import re
> + textrel_re = re.compile("\s+TEXTREL\s+")
> + for line in phdrs.split("\n"):
> + if textrel_re.match(line):
> + sane = False
> +
> + if not sane:
> + messages.append("ELF binary '%s' has relocations in .text" % path)
> +
> QAPATHTEST[ldflags] = "package_qa_hash_style"
> def package_qa_hash_style(path, name, d, elf, messages):
> """
More information about the Openembedded-core
mailing list