[OE-core] [PATCH 2/2] meta: remove redundant _FOR_BUILD variables

Richard Purdie richard.purdie at linuxfoundation.org
Sat Nov 10 10:05:05 UTC 2012


On Fri, 2012-11-09 at 21:23 -0200, Otavio Salvador wrote:
> On Fri, Nov 9, 2012 at 8:57 PM, Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
>         On Fri, 2012-11-09 at 20:32 -0200, Otavio Salvador wrote:
>         > On Fri, Nov 9, 2012 at 8:09 AM, Ross Burton
>         <ross.burton at intel.com>
>         > wrote:
>         >         Signed-off-by: Ross Burton <ross.burton at intel.com>
>         >
>         > Please bump PR. Even it might not change the end result we
>         need to
>         > force a rebuild as we did change the meta-data and we risk
>         having a
>         > subtle bug somewhere.
>
>         This patch set adds a number of exports to autotools.bbclass.
>         In doing
>         so, the sstate checksums will change for pretty much
>         everything and
>         hence pretty much everything will rebuild. Using PR
>         specifically to
>         force a rebuild is therefore unnecessary.
>
> If it rebuilds it might get a different binary package and for
> preserve the upgrade path PR bumps are need, aren't they?

Technically you are correct (I took your comment above to refer to
rebuilding the recipes). Technically we should bump PR for every recipe
using the autotools class.

We don't however bump PR of every recipe every time we change the core
classes and there is plenty of precedent for not doing that.

This is basically why I think the whole "PR bump" thing is flawed and we
should stop doing it in favour of some automated mechanism like PR
service. This is why its high on the 1.4 feature list since I've had
enough of this madness.

I'm not going to ask Ross to spend the hour it would take to manually
bump PR for each recipe using autotools and even that won't account for
PR in other layers.

Cheers,

Richard






More information about the Openembedded-core mailing list