[OE-core] [PATCH] bash: Add fix for cross compile issues
Richard Purdie
richard.purdie at linuxfoundation.org
Wed Nov 14 14:14:54 UTC 2012
On Wed, 2012-11-14 at 07:08 -0700, Chris Larson wrote:
> On Wed, Nov 14, 2012 at 6:01 AM, Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
> > The reason for this failure has to do with a particular set
> of
> > circumstances. A header in the bash source tree defines
> STRING() based
> > on HAVE_STRINGIZE. This define overwrites the unistd.h
> define of the
> > same macro. The unistd.h definitions of read() and open()
> wrap the
> > call to the real functions to implement FORTIFY_SOURCES, and
> those
> > wrappers use STRING() to do it. As a result, for any host
> that
> > defaults to -DFORTIFY_SOURCES, STRING() returns 'x'
> resulting in a
> > concatenation rather than an assembly level rename of the
> function
> > being called.
> >
> > If we add -DHAVE_STRINGIZE in the CROSS_COMPILE case, then
> STRING()
> > will be defined to something useful, and therefore the
> FORTIFY_SOURCES
> > wrappers don't get hosed.
> >
> > See
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-mentor/commit/?id=da0ff91 for an alternative fix which may be more likely to be accepted upstream.
> >
>
> This is better, yes. Is there a reason this is in meta-mentor
> and not
> OE-Core? I'd really like to pull it into OE-Core...
>
> Nope, it's just in the pending upstream pile. I'll send a patch
> against oe-core to the list today if you'd like.
Please, I'd like to get that problem fixed.
Cheers,
Richard
More information about the Openembedded-core
mailing list