[OE-core] [PATCH] utils: Optimise looping in base_set_filespath
Richard Purdie
richard.purdie at linuxfoundation.org
Mon Nov 19 23:44:16 UTC 2012
Calling split on the same expression, once per loop iteration is
inefficient and pointless, particularly in a function called by
every recipe during parsing.
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 52e511f..c1de2f6 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -308,10 +308,10 @@ def base_set_filespath(path, d):
if extrapaths != "":
path = extrapaths.split(":") + path
# The ":" ensures we have an 'empty' override
- overrides = (d.getVar("OVERRIDES", True) or "") + ":"
+ overrides = ((d.getVar("OVERRIDES", True) or "") + ":").split(":")
for p in path:
if p != "":
- for o in overrides.split(":"):
+ for o in overrides:
filespath.append(os.path.join(p, o))
return ":".join(filespath)
More information about the Openembedded-core
mailing list