[OE-core] [PATCH] sstate: Add detail to shared area warning

Phil Blundell philb at gnu.org
Tue Oct 2 22:05:08 UTC 2012


On Tue, 2012-10-02 at 15:06 -0700, Saul Wold wrote:
> On 10/02/2012 03:00 PM, Phil Blundell wrote:
> > On Tue, 2012-10-02 at 15:00 -0700, Saul Wold wrote:
> >> -        bb.warn("The recipe is trying to install files into a shared area when those files already exist. Those files are:\n   %s" % "\n   ".join(match))
> >> +        bb.warn("The %s recipe is trying to install files into a shared area when those files already exist (please fix %s). Those files are:\n   %s" % (d.getVar('PN', True), d.getVar('FILE', True), "\n   ".join(match)))
> >
> > That seems potentially misleading: the file that needs fixing isn't
> > necessarily the one that triggers this warning.  What would be ideal
> > would be to have it output the names of all recipes that have tried to
> > stage the files in question so that the user can make an informed
> > decision about which one ought to be putting them there.
> >
> True enough, but we don't have that information at that time, but it 
> gives more information than we had before, as to which recipe was adding 
> the files, I guess if I change the wording to something like
> "verify" or "check"?

Yeah, sounds good.

p.





More information about the Openembedded-core mailing list