[OE-core] [PATCH 1/2] PACKAGES_DYNAMIC: use regexp not glob

[Martin Jansa]

On Tue, Oct 16, 2012 at 12:39:34PM -0700, Saul Wold wrote:
> On 10/12/2012 10:56 AM, Martin Jansa wrote:
> > On Fri, Oct 12, 2012 at 10:40:56AM -0700, Saul Wold wrote:
> >> On 10/12/2012 03:46 AM, Martin Jansa wrote:
> >>> * bitbake uses PACKAGES_DYNAMIC as regexp
> >>>     ^ could make matching faster (and it will be more clear that we're expecting regexp not glob)
> >>>     * made all those last '-' optional, use .* (or nothing)
> >>>
> >>> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> >>> ---
> >>>    meta/classes/kernel.bbclass                              | 6 +++---
> >>>    meta/conf/bitbake.conf                                   | 2 +-
> >>>    meta/recipes-connectivity/connman/connman.inc            | 2 +-
> >>>    meta/recipes-core/eglibc/eglibc-locale.inc               | 6 +++---
> >>>    meta/recipes-core/packagegroups/packagegroup-core-sdk.bb | 2 +-
> >>>    meta/recipes-devtools/perl/perl_5.14.2.bb                | 4 ++--
> >>>    meta/recipes-extended/lighttpd/lighttpd_1.4.31.bb        | 2 +-
> >>>    meta/recipes-extended/pam/libpam_1.1.6.bb                | 2 +-
> >>>    meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb       | 2 +-
> >>>    meta/recipes-gnome/gtk+/gtk+_2.24.8.bb                   | 2 +-
> >>>    meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb     | 2 +-
> >>>    meta/recipes-graphics/directfb/directfb.inc              | 2 +-
> >>>    meta/recipes-graphics/mesa/mesa-dri.inc                  | 2 +-
> >>>    meta/recipes-graphics/pango/pango.inc                    | 2 +-
> >>>    meta/recipes-kernel/linux/linux-dummy.bb                 | 4 ++--
> >>>    meta/recipes-multimedia/gstreamer/gst-plugins.inc        | 2 +-
> >>>    meta/recipes-multimedia/pulseaudio/pulseaudio.inc        | 2 +-
> >>>    meta/recipes-qt/qt-apps/qmmp_0.6.1.bb                    | 2 +-
> >>>    meta/recipes-qt/qt4/qt4-embedded.inc                     | 2 +-
> >>>    meta/recipes-qt/qt4/qt4.inc                              | 2 +-
> >>>    20 files changed, 26 insertions(+), 26 deletions(-)
> >>>
> >> Martin,
> >>
> >> Did you do any verification with the buildhistory tools to ensure
> >> nothing changed in the packaging?
> >
> > Yes, last 12 commits in
> > https://github.com/shr-distribution/buildhistory/commits/jama
> >
> > e.g. for om-gta02
> > https://github.com/shr-distribution/buildhistory/commit/55d9cb4fa438e64c9fcc4ef0966164779c5dc974
> > https://github.com/shr-distribution/buildhistory/commit/c0b3897e04fd9669c557620ca48fde05f01e7aca
> >
> > but it's together with last change to perl, eglibc, pkgconfig.
> >
> I did track down this failure to your change, possibly something missed 
> in kernel.bbclass:
> 
> > ERROR: Nothing RPROVIDES 'kernel-modules' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-mips/build/meta/recipes-core/packagegroups/packagegroup-base.bb RDEPENDS on or otherwise requires it)
> > NOTE: Runtime target 'kernel-modules' is unbuildable, removing...
> > Missing or unbuildable dependency chain was: ['kernel-modules']
> > NOTE: Runtime target 'packagegroup-base-extended' is unbuildable, removing...
> > Missing or unbuildable dependency chain was: ['packagegroup-base-extended', 'kernel-modules']

True, kernel-module-* was also matching kernel-modules which is added to
PACKAGES later in python.

I'm sending 2 alternative patches to resolve this
1) adding ^kernel-modules$ to PACKAGES_DYNAMIC
   
2) adding kernel-modules as normal package to PACKAGES and simplify 
   populate_packages_prepend

I prefer 2nd solution, but maybe someone will find some reason why 1st is
better.

> I was attempting to build core-image-sato and core-image-sato-sdk on 
> qemumips or routerstation, I was able to see this failure on other 
> MACHINES also.
> 
> Thanks

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20121017/20fd9372/attachment-0002.sig>