[OE-core] [OE-Core][PATCH] base-files: do_install_basefilesissue error

Giuseppe Condorelli giuseppe.condorelli at gmail.com
Tue Oct 23 09:00:29 UTC 2012


Hi Richard,

indeed this patch was erroneously sent twice and in the other one it was
replied the mistake was solved and it is no more valid.
Please discard it as already suggested in the other thread.
Thanks,
Giuseppe

2012/10/23 Richard Purdie <richard.purdie at linuxfoundation.org>

> On Tue, 2012-10-23 at 08:45 +0200, Giuseppe CONDORELLI wrote:
> > Fixed error in do_install_basefilesissue, printf is now replaced by echo.
>
> What kind of error?
>
> Doesn't this change have issues about how newlines are handled?
>
> Cheers,
>
> Richard
>
>
> > Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli at st.com>
> > ---
> >  meta/recipes-core/base-files/base-files_3.0.14.bb |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bbb/meta/recipes-core/base-files/
> base-files_3.0.14.bb
> > index ba355ee..766b0e5 100644
> > --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> > +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > @@ -117,11 +117,11 @@ do_install_basefilesissue () {
> >
> >       install -m 644 ${WORKDIR}/issue*  ${D}${sysconfdir}
> >          if [ -n "${DISTRO_NAME}" ]; then
> > -             printf "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue
> > -             printf "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue.net
> > +             echo "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue
> > +             echo "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue.net
> >               if [ -n "${DISTRO_VERSION}" ]; then
> > -                     printf "${DISTRO_VERSION} " >>
> ${D}${sysconfdir}/issue
> > -                     printf "${DISTRO_VERSION} " >> ${D}${sysconfdir}/
> issue.net
> > +                     echo "${DISTRO_VERSION} " >>
> ${D}${sysconfdir}/issue
> > +                     echo "${DISTRO_VERSION} " >> ${D}${sysconfdir}/
> issue.net
> >               fi
> >               echo "\n \l" >> ${D}${sysconfdir}/issue
> >               echo >> ${D}${sysconfdir}/issue
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20121023/e2e36507/attachment-0002.html>


More information about the Openembedded-core mailing list