[OE-core] [oe][PATCH 1/3] latencytop: disable GTK and remove gtk+ dependacy
Jack Mitchell
ml at communistcode.co.uk
Fri Oct 26 12:37:04 UTC 2012
On 26/10/12 13:35, Jack Mitchell wrote:
> On 26/10/12 13:28, Paul Eggleton wrote:
>> On Friday 26 October 2012 12:54:18 Jack Mitchell wrote:
>>> From: Jack Mitchell <jack.mitchell at dbbroadcast.co.uk>
>>>
>>> ---
>>>
>>> v2
>>> - Don't use -D to define with make
>>> - Rename EXTRA_OECONF_X to EXTRA_OEMAKE_X
>>>
>>> When DISTRO_FEATURES does not contain x11, disable GTK GUI and
>>> also don't add gtk+ to the DEPENDS
>>>
>>> Signed-off-by: Jack Mitchell <jack.mitchell at dbbroadcast.co.uk>
>> I think because the commit message is below the first --- it won't be
>> picked up
>> when applied. This is probably where a cover letter is more appropriate.
>>
>> Cheers,
>> Paul
>>
>
> Bah! One of these days I will get it right.
>
> I think [1] should be updated for a few more use cases e.g. multiple
> patches.
>
> So you're saying I should do:
>
> git send-email -3 --no-chain-reply-to --cover-letter --to
> openembedded-core at lists.openembedded.org --subject-prefix=oe][PATCH
>
> And also remove the '---' from my commit message on patch 1?
>
[1] http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
--
Jack Mitchell (jack at embed.me.uk)
Embedded Systems Engineer
http://www.embed.me.uk
--
More information about the Openembedded-core
mailing list