[OE-core] runstrip() in package.bbclass fails when run against a kernel module

[Tomas Frydrych]

Hi,

On 03/09/12 08:08, Martin Jansa wrote:
> On Fri, Aug 31, 2012 at 12:53:31PM +0100, Tomas Frydrych wrote:
>>
>> runstrip() in package.bbclass fails when run against a kernel module,
>> because it tries to do a bitwise & with a 'None' argument. This throws:
>> TypeError: unsupported operand type(s) for &: 'NoneType' and 'int'.
> 
> Was this for denzil?
> 
> In master it was fixed a month ago by:
> http://git.openembedded.org/openembedded-core/commit/meta/classes/package.bbclass?id=a834ab8a6d53cae504fa112a89bab93d726539ec
> 
> Don't know why they merged your patch to master too now..

Yes, I run into the bug on Denzil and did not see the alternative fix in
master; either one of those fixes the problem, of course.

Tomas


> 
> Cheers,
> 
>>
>> Tomas
>>
> 
>> From 6abe978d8e0acdb35c1abfed83e775b276b1231f Mon Sep 17 00:00:00 2001
>> From: Tomas Frydrych <tomas at sleepfive.com>
>> Date: Fri, 31 Aug 2012 12:02:18 +0100
>> Subject: [PATCH] package.bbclass: fix stripping for kernel modules
>>
>> runstrip(path, elftype, d) does bitwise & on the elftype parameter, so it has
>> to be passed an integer. Passing None fails with: TypeError: unsupported
>> operand type(s) for &: 'NoneType' and 'int'.
>>
>> Signed-off-by: Tomas Frydrych <tomas at sleepfive.com>
>> ---
>>  meta/classes/package.bbclass |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
>> index 44e551f..f046fbb 100644
>> --- a/meta/classes/package.bbclass
>> +++ b/meta/classes/package.bbclass
>> @@ -877,7 +877,7 @@ python split_and_strip_files () {
>>  			for f in files:
>>  				if not f.endswith(".ko"):
>>  					continue
>> -				runstrip(os.path.join(root, f), None, d)
>> +				runstrip(os.path.join(root, f), 0, d)
>>  	#
>>  	# End of strip
>>  	#
>> -- 
>> 1.7.10.4
>>
>>
> 
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
>