[OE-core] [PATCH] packageinfo.bbclass: Fix crash in hob

[Jason Wessel]

On 09/06/2012 03:36 PM, Paul Eggleton wrote:
> On Thursday 06 September 2012 13:53:54 Jason Wessel wrote:
>> The hob internally fails after executing a build and invoking
>> the hob a second time when it tries to use the values found in
>> BUILDDIR/tmp/pkgdata/*/runtime/*
>>
>> The internal failure of the hob will manifest itself as
>> stating "Populated recipes 99%" forever after selecting
>> a machine just after starting the hob interface.
>>
>> The internal trace looks like:
>>
>> Traceback (most recent call last):
>> File "packageinfo_handler(e)", line 24, in packageinfo_handler
>> KeyError: 'PKGV'
>>
>> It is a result of using an override for a package version for
>> pieces of the toolchain, in the bb file e.g.
>> PKGV_gdb-dbg = "1234.5678"
>>
>> The work around for now is to populate the sdata PKGV value
>> and to assign the pkgv variable with the correct value
>> from the values found in the pkgdata store.
>>
>> Signed-off-by: Jason Wessel <jason.wessel at windriver.com>
>> ---
>> meta/classes/packageinfo.bbclass | 7 ++++++-
>> 1 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/packageinfo.bbclass
>> b/meta/classes/packageinfo.bbclass index 26cce60..53965e4 100644
>> --- a/meta/classes/packageinfo.bbclass
>> +++ b/meta/classes/packageinfo.bbclass
>> @@ -18,7 +18,12 @@ python packageinfo_handler () {
>> sdata = oe.packagedata.read_pkgdatafile(root +
>> pkgname) sdata['PKG'] = pkgname
>> pkgrename = sdata['PKG_%s' % pkgname]
>> - pkgv = sdata['PKGV'].replace('-', '+')
>> + try:
>> + pkgv = sdata['PKGV']
>> + except:
>> + sdata['PKGV'] = sdata['PKGV_%s' % pkgname]
>> + pkgv = sdata['PKGV']
>> + pkgv = pkgv.replace('-', '+')
>> pkgr = sdata['PKGR']
>> # We found there are some renaming issue with
>> certain architecture. # For example, armv7a-vfp-neon, it will use armv7a in
>> the rpm file. This is the workaround for it.
>
> Rather than a blanket try...except which could catch other errors I would
> suggest using .get() to which you can supply a default value if no such key
> exists in the dict.
>
> I'm afraid I didn't get around to determining whether we should be recording
> these package name overrides in the pkgdata files today, I will check into that
> tomorrow.
>

Honestly I don't care how we fix it, and I believe the fix I proposed
should be changed over to the writer side.  If nothing else this patch
is meant to illustrate or call out the problem.

You'll note I had to actually set the sdata['PKGV'] because it turns
out it is used directly elsewhere in the hob and things started
falling over without fixing it.  This leads us to the possibility that
the writer of the data store is probably wrong, at least for PKGV
anyway.  On the other hand there might be other implicit assumptions
that are broken.

What I find odd is that this does work when the pkgdata store is not
there which leads me to believe it was never written out properly in
the first place or the data isn't always needed.  The hob, to me looks
like a piece of spaghetti, so without further investigation I cannot
make a concise claim about the correct fix.  I am hoping someone else
might take a further look at it who knows more about the hob
interface.

Jason.