[OE-core] [PATCH] perf: Refactor code so it is easier to read
Saul Wold
sgw at linux.intel.com
Thu Sep 13 20:40:03 UTC 2012
On 09/13/2012 01:32 PM, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
> meta/recipes-kernel/perf/perf_3.4.bb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
> index decc911..6e1c746 100644
> --- a/meta/recipes-kernel/perf/perf_3.4.bb
> +++ b/meta/recipes-kernel/perf/perf_3.4.bb
> @@ -74,7 +74,7 @@ do_compile() {
> do_install() {
> oe_runmake DESTDIR=${D} install
> # we are checking for this make target to be compatible with older perf versions
> - if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
> + if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ] && ! grep -q install-python_ext ${S}/tools/perf/Makefile ]; then
Is this missing a [ or is there an extra ]?
Also is that dash compliant?
And of course you need a PR bump (well maybe not in this case)
Sau!
> oe_runmake DESTDIR=${D} install-python_ext
> fi
> }
>
More information about the Openembedded-core
mailing list