[OE-core] [PATCH v2] insane.bbclass: add library dir sanity check
Radu Moisan
radu.moisan at intel.com
Fri Sep 14 09:18:22 UTC 2012
Added comments.
radu
On 09/14/2012 12:03 PM, Radu Moisan wrote:
> Check in ${PKGD} for libraries in other locations
> then ${libdir}. Trigger a warning if so.
>
> [Yocto #2038]
>
> Signed-off-by: Radu Moisan <radu.moisan at intel.com>
> ---
> meta/classes/insane.bbclass | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index e74eb3f..6388609 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -212,6 +212,18 @@ def package_qa_check_staticdev(path, name, d, elf, messages):
> messages.append("non -staticdev package contains static .a library: %s path '%s'" % \
> (name, package_qa_clean_path(path,d)))
>
> +def package_qa_check_libdir(path,libdir):
> + """
> + Check in path for libraries in other locations then libdir. Trigger a warning if so.
> + """
> + import re
> + lib_re = re.compile("^.*\.(so|a)")
> + for root, dirs, files in os.walk(path):
> + if libdir not in root:
> + for file in files:
> + if lib_re.match(file):
> + bb.warn("Found library in wrong location: %s" % os.path.join(root,file))
> +
> QAPATHTEST[debug-files] = "package_qa_check_dbg"
> def package_qa_check_dbg(path, name, d, elf, messages):
> """
> @@ -688,6 +700,12 @@ python do_package_qa () {
> rdepends_sane = False
>
>
> + ml = d.getVar("MLPREFIX", True) or ""
> + if ml:
> + pkgd = d.getVar('PKGD', True)
> + libdir = d.getVar("libdir", True)
> + package_qa_check_libdir(pkgd,libdir)
> +
> if not walk_sane or not rdepends_sane:
> bb.fatal("QA run found fatal errors. Please consider fixing them.")
> bb.note("DONE with PACKAGE QA")
More information about the Openembedded-core
mailing list