[OE-core] [PATCH] intltool: include intltool.m4 and add missing rdepends

[Constantin Musca]

On 09/18/2012 11:40 PM, Saul Wold wrote:
> On 09/18/2012 09:49 AM, Saul Wold wrote:
>> On 09/18/2012 06:33 AM, Constantin Musca wrote:
>>> - include /usr/share/aclocal/intltool.m4 into the intltool
>>> package (the files from intltool-dev must be included into the
>>> main package, as intltool is a development tool)
>>> - add missing rdepends: gettext-dev, libxml-parser-perl
>>>
>>> [YOCTO #2597]
>>>
>>> Signed-off-by: Constantin Musca <constantinx.musca at intel.com>
>>> ---
>>>   meta/recipes-devtools/intltool/intltool_0.50.0.bb |    9 ++++++++-
>>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/intltool/intltool_0.50.0.bb
>>> b/meta/recipes-devtools/intltool/intltool_0.50.0.bb
>>> index d1ee31d..52de5df 100644
>>> --- a/meta/recipes-devtools/intltool/intltool_0.50.0.bb
>>> +++ b/meta/recipes-devtools/intltool/intltool_0.50.0.bb
>>> @@ -1,7 +1,7 @@
>>>   require intltool.inc
>>>   LICENSE="GPLv2"
>>>   LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>> -PR = "r0"
>>> +PR = "r1"
>>>
>>>   SRC_URI += "file://intltool-nowarn-0.50.0.patch \
>>>              ${NATIVEPATCHES} \
>>> @@ -17,3 +17,10 @@ NATIVEPATCHES_virtclass-native =
>>> "file://use-nativeperl.patch"
>>>
>>>   SRC_URI[md5sum] = "0da9847a60391ca653df35123b1f7cc0"
>>>   SRC_URI[sha256sum] =
>>> "dccfb0b7dd35a170130e8934bfd30c29da6ae73bcd3ca4ba71317c977b2893d6"
>>> +
>>> +RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
>>> +
>> I am not sure that this is the right thing to do here, this might cause
>> some problems if you try to build the native variation of intltool??
>>
> I should have included the failure:
>
>> ERROR: Nothing RPROVIDES 'gettext-dev-native' (but 
>> virtual:native:/intel/poky/distro/meta/recipes-devtools/intltool/intltool_0.50.0.bb 
>> RDEPENDS on or otherwise requires it)
>> NOTE: Runtime target 'gettext-dev-native' is unbuildable, removing...
>> Missing or unbuildable dependency chain was: ['gettext-dev-native']
>
> Not sure how you tested this, as it failed right away for me!
>
> Sau!
>
>> Sau!
>>
>>> +FILES_${PN}-dev = ""
>>> +FILES_${PN} += "${datadir}/aclocal"
>>> +
>>> +INSANE_SKIP_${PN} += "dev-deps"
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
I think that my setup was messed up. I will send patch v2.

Constantin