[OE-core] [PATCH v2] intltool: include intltool.m4 and add missing rdepends

[Khem Raj]

On Wed, Sep 19, 2012 at 2:59 AM, Constantin Musca
<constantinx.musca at intel.com> wrote:
> - include /usr/share/aclocal/intltool.m4 into the intltool
> package (the files from intltool-dev must be included into the
> main package, as intltool is a development tool)
> - add missing rdepends: gettext-dev, libxml-parser-perl
>
> [YOCTO #2597]
>
> Signed-off-by: Constantin Musca <constantinx.musca at intel.com>
> ---
>  meta/recipes-devtools/intltool/intltool.inc       |    9 ++++++++-
>  meta/recipes-devtools/intltool/intltool_0.50.0.bb |    2 +-
>  2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
> index 1c41f0f..59974d8 100644
> --- a/meta/recipes-devtools/intltool/intltool.inc
> +++ b/meta/recipes-devtools/intltool/intltool.inc
> @@ -7,11 +7,18 @@ SRC_URI = "http://launchpad.net/${BPN}/trunk/${PV}/+download/${BP}.tar.gz"
>  S = "${WORKDIR}/intltool-${PV}"
>
>  DEPENDS = "libxml-parser-perl-native"
> +RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"

creating a runtime dependency on a dev package seems troublesome to me.
Can you explain why is this being done ?

>  DEPENDS_virtclass-native = "libxml-parser-perl-native"
> -#RDEPENDS_${PN} = "libxml-parser-perl"
> +# gettext is assumed to exist on the host
> +RDEPENDS_${PN}_virtclass-native = "libxml-parser-perl-native"
>  RRECOMMENDS_${PN} = "perl-modules"
>  RRECOMMENDS_${PN}_virtclass-native = ""
>
> +FILES_${PN}-dev = ""
> +FILES_${PN} += "${datadir}/aclocal"
> +
> +INSANE_SKIP_${PN} += "dev-deps"
> +
>  inherit autotools pkgconfig perlnative
>
>  export PERL = "${bindir}/env perl"
> diff --git a/meta/recipes-devtools/intltool/intltool_0.50.0.bb b/meta/recipes-devtools/intltool/intltool_0.50.0.bb
> index d1ee31d..fa9850f 100644
> --- a/meta/recipes-devtools/intltool/intltool_0.50.0.bb
> +++ b/meta/recipes-devtools/intltool/intltool_0.50.0.bb
> @@ -1,7 +1,7 @@
>  require intltool.inc
>  LICENSE="GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
> -PR = "r0"
> +PR = "r1"
>
>  SRC_URI += "file://intltool-nowarn-0.50.0.patch \
>             ${NATIVEPATCHES} \
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core