[OE-core] [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers

[Chris Larson]

On Mon, Sep 24, 2012 at 1:43 PM, McClintock Matthew-B29882
<B29882 at freescale.com> wrote:
> On Mon, Sep 24, 2012 at 3:06 PM, Matthew McClintock <msm at freescale.com> wrote:
>> On Mon, Sep 24, 2012 at 3:00 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
>>> On Mon, Sep 24, 2012 at 02:55:45PM -0500, Matthew McClintock wrote:
>>>> Fixes these sorts of issues present on older gcc (CentOS 5.x in this case)
>>>>
>>>> | cc1: error: unrecognized command line option "-Werror=implicit"
>>>> | cc1: error: unrecognized command line option "-Werror=nonnull"
>>>> | cc1: error: unrecognized command line option "-Werror=init-self"
>>>> | cc1: error: unrecognized command line option "-Werror=main"
>>>> | cc1: error: unrecognized command line option "-Werror=missing-braces"
>>>> | cc1: error: unrecognized command line option "-Werror=sequence-point"
>>>> | cc1: error: unrecognized command line option "-Werror=return-type"
>>>> | cc1: error: unrecognized command line option "-Werror=trigraphs"
>>>> | cc1: error: unrecognized command line option "-Werror=array-bounds"
>>>> | cc1: error: unrecognized command line option "-Werror=write-strings"
>>>> | cc1: error: unrecognized command line option "-Werror=address"
>>>> | cc1: error: unrecognized command line option "-Werror=int-to-pointer-cast"
>>>> | cc1: error: unrecognized command line option "-Werror=pointer-to-int-cast"
>>>
>>> Shouldn't it be applied only for -native? version?
>>
>> That's reasonable. But, suppressing warnings to compile logs also did
>> not seem to matter much since we don't go line by line on warnings in
>> compile logs (does anyone?). I'll go with the consensus though.
>
> Actually, this makes sense now because I'm seeing issues with
> non-nativesdk packages with the '-e' I've added... thought I build
> tested that... ;(

Why is -e being added? It's almost always better to add the vars you
need explicitly, imo. I wish we could change the default EXTRA_OEMAKE
to drop it, personally. It can cause odd unintended consequences.
-- 
Christopher Larson