[OE-core] [PATCH 2/2] libx11: fix nativesdk build on older distros

[McClintock Matthew-B29882]

On Tue, Sep 25, 2012 at 12:38 PM, Matthew McClintock <msm at freescale.com> wrote:
> On Tue, Sep 25, 2012 at 11:48 AM, Burton, Ross <ross.burton at intel.com> wrote:
>> Whoops, I dropped oe-core.
>>
>> On 25 September 2012 16:38, McClintock Matthew-B29882
>> <B29882 at freescale.com> wrote:
>>>>> Older libc do not have this defined, we can use the -D_GNU_SOURCE
>>>>> to the compiler to prevent generating calls to this function and
>>>>> make linking work
>>>>
>>>> Why isn't this from configure.ac working?
>>>>
>>>> # Set common system defines for POSIX extensions, such as _GNU_SOURCE
>>>> # Must be called before any macros that run the compiler (like AC_PROG_LIBTOOL)
>>>> # to avoid autoconf errors.
>>>> AC_USE_SYSTEM_EXTENSIONS
>>>
>>> Do these make it to CC_FOR_BUILD? Here is what it looks like before:
>>
>> AC_USE_SYSTEM_EXTENSIONS sets _GNU_SOURCE (and more) using AC_DEFINE,
>> so they end up in config.h... which isn't being included in
>> makekeys.c.
>>
>> So the correct and upstreamable fix is to include config.h from makekeys.c.
>
> I read somewhere (very informative - I know - but I've forgot where)
> that you are not supposed to include config.h for CC_FOR_BUILD
> targets? I'm not expert and just double checking on this bit as the
> correct solution.

Found it: http://sources.redhat.com/autobook/autobook/autobook_270.html

-M