[OE-core] [PATCH] gcc-configure-cross: factor out --enable-threads argument into ${GCCTHREADS}

[Martin Jansa]

On Wed, Sep 26, 2012 at 10:57:41AM +0100, Phil Blundell wrote:
> On Wed, 2012-09-26 at 11:54 +0200, Martin Jansa wrote:
> > On Wed, Sep 26, 2012 at 10:45:18AM +0100, Phil Blundell wrote:
> > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > > index 908ad3e..504bfaa 100644
> > > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > > @@ -26,12 +26,13 @@ EXTRA_OECONF_INITIAL ?= ""
> > >  EXTRA_OECONF_INTERMEDIATE ?= ""
> > >  
> > >  GCCMULTILIB = "--disable-multilib"
> > > +GCCTHREADS = "posix"
> > >  
> > >  EXTRA_OECONF = "${@['--enable-clocale=generic', ''][d.getVar('USE_NLS', True) != 'no']} \
> > >                  --with-gnu-ld \
> > >                  --enable-shared \
> > >                  --enable-languages=${LANGUAGES} \
> > > -                --enable-threads=posix \
> > > +                --enable-threads=${GCCTHREADS} \
> > >                  ${GCCMULTILIB} \
> > >                  --enable-c99 \
> > >                  --enable-long-long \
> > > -- 
> > > 1.7.10.4
> > 
> > Missing PR bump
> 
> Does it really need one?  It doesn't have any impact on the value that
> EXTRA_OECONF ends up with, and bumping the PRs on all the various .bb
> files would make the patch about ten times the size.  I can do that if
> you insist but it seems like a bit of a waste of time.

Sorry I haven't noticed that it's the same value as before. 

But if it causes different sstate checksum than PR bump would be nice to get new
builddir (well maybe not needed after f15f61af77cc4e52a037f509f8e49e1ea530cf35).

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120926/0cbd9454/attachment-0002.sig>