[OE-core] [PATCH] Add file information to package information window

Richard Purdie richard.purdie at linuxfoundation.org
Wed Apr 3 13:30:45 UTC 2013


On Wed, 2013-04-03 at 14:58 +0300, Andrei Dinu wrote:
> Removed the package files parsing routine from the
> packageinfo.bbclass file and added it to the
> package.bbclass file.
> 
> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu at intel.com>
> ---
>  meta/classes/package.bbclass     |   14 ++++++++++++++
>  meta/classes/packageinfo.bbclass |   20 --------------------
>  2 files changed, 14 insertions(+), 20 deletions(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 3479947..121a1dd 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1130,6 +1130,17 @@ python emit_pkgdata() {
>      workdir = d.getVar('WORKDIR', True)
>  
>      for pkg in packages.split():
> +        pkgdest = d.getVar('PKGDEST', True)
> +        files_path = pkgdest + '/' + pkg
> +        if os.path.exists(files_path):
> +                items = {}
> +                for path, dirs, files in os.walk(files_path):
> +                        files_list = []
> +                        if os.listdir(path) != []:
> +                            for f in files:
> +                                files_list.append(f)
> +                        if len(files_list) != 0:
> +                            items[path] = files_list           
>          subdata_file = pkgdatadir + "/runtime/%s" % pkg

You're now doing this in a "fastpath" so we need to look carefully at
performance here. Can you have a look at the pkgfiles[pkg] variable and
see if you can get the data you need from that? You should be able to
iterate it and just strip out the prefixes?

Cheers,

Richard






More information about the Openembedded-core mailing list