[OE-core] [PATCH] gdk-pixbuf: Fix libpng determinism issues

[Koen Kooi]

Op 15 apr. 2013, om 12:08 heeft Colin Walters <walters at verbum.org> het volgende geschreven:

> On Sun, 2013-04-14 at 16:33 +0100, Richard Purdie wrote:
>> On Sun, 2013-04-14 at 09:02 -0400, Colin Walters wrote:
>> The more interesting change is:
>> 
>> https://git.gnome.org/browse/gdk-pixbuf/commit/configure.ac?id=d430bc4df3314a88cd538474d26ff7764d1f408c
>> 
>> and following that to the bugzilla 'For this to make sense, I changed
>> the order so that a version specific dep, such as libpng15 or
>> libpng12,
>> is found before just "libpng".'
>> 
>> I'm not sure I entirely follow that logic.
> 
> I added Matthias to CC as he touched this last then.
> 
>> I think the intent of the symlink is to provide the system with a
>> default libpng to use in the absence of a specific version requirement.
>> As the code stands today, each time a new libpng comes out, gdk-pixbuf
>> will need changes before it will be able to use it. 
> 
> Right, we need configure.ac changes, but the rationale behind that is
> that we'd also need *code* changes for each new major version of libpng.
> But it sounds like what you're saying is that gdk-pixbuf compiles and
> operates correctly with 1.6?  If that's the case, then the least
> invasive change here is to simply add 1.6.
> 
> Blah, I tried changing the gnome-ostree build to fetch libpng's v1.6.1
> git tag to test, but it hard requires Automake 1.13.

Only for parallel unit tests, I just sent a patch to update libpng to v1.6.1 to oe-core. It doesn't fix the problems I'm having with PNGs in weston, so please test it and see if it fixed any of your problems.

regards,

Koen

> 
> Anyways, if it works (looks like the latest oe-core has it), then
> what about the attached?
> 
>> In the meantime, it
>> will potentially link against something old, e.g. 1.2, since 1.2 is in
>> the LSB 4.X spec so most LSB like systems would have 1.6 and 1.2.
>> 
>> If we can justify changing this upstream, that would be great :). It may
>> be worth adding libpng16 into the list too so everything is covered too.
> 
> At this point I'm hoping the parade of libpng versions will
> settle down, so hopefully no further tweaking of the configure script or
> code will be required...
> 
> 
> <0001-build-We-also-support-libpng16.patch>_______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core