[OE-core] [PATCH] pango: add libpng to DEPENDS

[Koen Kooi]

Op 16 apr. 2013, om 12:08 heeft Richard Purdie <richard.purdie at linuxfoundation.org> het volgende geschreven:

> On Tue, 2013-04-16 at 11:59 +0200, Koen Kooi wrote:
>> Op 16 apr. 2013, om 11:54 heeft Richard Purdie <richard.purdie at linuxfoundation.org> het volgende geschreven:
>> 
>>> On Tue, 2013-04-16 at 11:10 +0200, Koen Kooi wrote:
>>>> Pango links indirectly to libpng through the cairo-png dependency, but
>>>> does encode the libpng version in its .la files. Changing libpng
>>>> versions will make a rebuild fail, so let's cheat a bit to let sstate
>>>> rebuild pango as well to get around this.
>>>> 
>>>> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
>>>> ---
>>>> meta/recipes-graphics/pango/pango.inc | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> This doesn't follow. If pango -> cairo -> libpng and libpng changes,
>>> both cairo and pango will rebuild.
>> 
>> If it did get rebuilt it still had references to non-existent
>> libpng16  .la in its .la files.
> 
> Autotools/libtool being broken then, the DEPENDS change might appear to
> help but it doesn't, only way to deal with it is either the change below
> or to clean the recipe in question.

OK, let's discard this patch :)

>>> What might be the problem is that autotools (or more likely libtool)
>>> isn't rebuilding correctly. This was solved with the separate build
>>> directory code. Have you enabled that?
>> 
>> Not that I know off. How do I do that?
> 
> http://git.yoctoproject.org/cgit.cgi/poky/commit/meta-yocto?id=9e366e153234114ab3c51e4bb8e3452593f64070
> 
> It was was made opt in since people didn't want it as the default. I've
> made it the default for poky as I believe its a good thing and helps
> cases like this.
> 
> The only downside is that to change to this you need a clean build
> directory as autotools throws a fit about this change when you re-run
> configure on an existing directory. Nothing we can do about that one,
> its autotools :(.

Thanks, I'll make it the default for angstrom as well.

regards,

Koen