[OE-core] [PATCH] packagegroup: Add init-manager sanity check

[Enrico Scholz]

Richard Purdie <richard.purdie at linuxfoundation.org> writes:

>> > Currently, you can set VIRTUAL-RUNTIME_init_manager to an init
>> > system that isn't in DISTRO_FEATURES. This leads to head scratching
>> > over unbootable images.
>> 
>> Because this sanity check is placed into an anonymous function, this
>> change affects also images which do not not include packagegroup-core*
>> in their images and are not using VIRTUAL-RUNTIME_init_manager at all.
>
> Affects in that it runs the anonymous python fragment but does nothing?

no; the 'parsing recipes' phase throws an exceptions

| ERROR: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES##                                                               | ETA:  00:00:14
| ERROR: Unable to parse /srv/oe/dev/org.openembedded.core/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb: Exited with "1"
| ERROR: Command execution failed: Exited with 1


Of course, I can BBMASK out these packagegroup-core recipes or simply
define VIRTUAL-RUNTIME_init_manager.


> Other proposals for solutions are welcome. I thought it better to
> catch a common user misconfiguration than generate broken images
> silently though.

You can put this check into e.g. do_configure[prefuncs].



Enrico