[OE-core] [PATCH] packagegroup: Add init-manager sanity check
Enrico Scholz
enrico.scholz at sigma-chemnitz.de
Thu Apr 18 12:25:09 UTC 2013
Richard Purdie <richard.purdie at linuxfoundation.org> writes:
>> no; the 'parsing recipes' phase throws an exceptions
>>
>> | ERROR: Please ensure that your setting of
>> | VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries
>> | enabled in DISTRO_FEATURES## | ETA: 00:00:14
>> | ERROR: Unable to parse
>> | /srv/oe/dev/org.openembedded.core/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb:
>> | Exited with "1"
>> | ERROR: Command execution failed: Exited with 1
>>
>>
>> Of course, I can BBMASK out these packagegroup-core recipes or simply
>> define VIRTUAL-RUNTIME_init_manager.
>
> Hmm, I understand now.
>
> The way I see this is that the system can't know if anything in your
> environment is going to use packagegroup-* or not.
Exactly; at this stage, the system does not known whether
VIRTUAL-RUNTIME_init_manager will ever be used and should not check it
there hence.
> Given that, I do think this is a valid warning
It's not a warning, but an error stopping the build
>> > Other proposals for solutions are welcome. I thought it better to
>> > catch a common user misconfiguration than generate broken images
>> > silently though.
>>
>> You can put this check into e.g. do_configure[prefuncs].
>
> So it errors at build time some time later? Where we can is it not
> better to inform the user of configuration issues earlier?
The differrence is that the anonymous python function fails regardless
whether VIRTUAL-RUNTIME_init_manager is used or not (and can not cause
problems hence).
The check in do_configure() will fail only, when it is really used.
I know that the check in the anonymous python function is executed very
early while the do_configure() check might trigger hours later. I do
not know whether such early warnings are really important; perhaps my
initial
| DEPENDS += "${@some_check(d)}"
suggestion could be enhanced so that some_check() throws an exception
and puts a note like the actual one.
Enrico
More information about the Openembedded-core
mailing list