[OE-core] [PATCH] cracklib: generate the default dictionary on the target

[Martin Donnelly]

On 25/04/2013 15:25, Mark Hatle wrote:
> On 4/25/13 8:28 AM, Martin Donnelly wrote:
>> Currently cracklib-native is used to generate the dictionary
>> database from the wordlist during install. Unfortunately the
>> database files are endian-specific and this results in
>> errors when the host and target endianness differ.
>>
>> This patch creates the default dictionary files on the target
>> during post-install. In order to do this the default wordlist has
>> also been compressed, this enables an unmodified cracklib-format
>> to correctly parse the input file with both busybox and GNU gzip.
>> (These behave differently if the input is uncompressed, GNU
>> gzip behaves like cat while busybox returns an error).
>>
>> Finally the cracklib-native package has been removed since
>> it is no longer used.
>
> I thought we had fixed cracklib to have a fixed endian.  If not, this is
> a bug.  We want to avoid running things like the cracklib generation on
> the target if possible, as it impacts the first boot time and read-only
> roots.
>

I had a look for any patches which fixed this but couldn't see any, 
there were some related to using dictionaries between 32 and 64-bit 
machines of the same endianness but I maybe missed another one? I wasn't 
100% happy sending it for the issues you mention but thought it better 
to post it than not.

> (I'm fine with this as a workaround, but it's not the fix I'd like.)
> I'd be happy if we simply fixed the cracklib-native to pass in an endian
> and have the right output generated.  (Note, we also have to consider
> structure alignment/packing as well.)
>

Agreed, this would be best and it's something I'll look at when I've got 
the time.

> If there isn't already a bug in the Yocto Project bugzilla, can you add
> one?
>

Done, https://bugzilla.yoctoproject.org/show_bug.cgi?id=4419

-Martin