[OE-core] [PATCH] connman: make tist functionallity a PACKAGECONFIG option

[Jack Mitchell]

On 26/04/13 11:16, Martin Jansa wrote:
> On Fri, Apr 26, 2013 at 11:06:11AM +0100, Jack Mitchell wrote:
>> From: Jack Mitchell <jack.mitchell at dbbroadcast.co.uk>
>>
>> Signed-off-by: Jack Mitchell <jack.mitchell at dbbroadcast.co.uk>
>> ---
>>
>> Runtime tested on beaglebone armv7a, with and without tist PACKAGECONFIG
>>
>>   meta/recipes-connectivity/connman/connman.inc | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
>> index 589ece8..eb9d145 100644
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -20,10 +20,7 @@ DEPENDS  = "dbus glib-2.0 ppp iptables gnutls \
>>               ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
>>               "
>>   
>> -INC_PR = "r19"
>> -
>> -TIST = "--enable-tist"
>> -TIST_powerpc = ""
>> +INC_PR = "r20"
>>   
>>   EXTRA_OECONF += "\
>>       ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
>> @@ -32,8 +29,8 @@ EXTRA_OECONF += "\
>>       --enable-threads \
>>       --enable-loopback \
>>       --enable-ethernet \
>> -    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
>> -    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
>> +    ${@base_contains('DISTRO_FEATURES', 'wifi', '--enable-wifi', '--disable-wifi', d)} \
>> +    ${@base_contains('DISTRO_FEATURES', 'bluetooth', '--enable-bluetooth', '--disable-bluetooth', d)} \
>>       ${@base_contains('DISTRO_FEATURES', '3g', '--enable-ofono', '--disable-ofono', d)} \
>>       --enable-tools \
>>       --enable-test \
>> @@ -43,6 +40,10 @@ EXTRA_OECONF += "\
>>       ${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', d)} \
>>   "
>>   
>> +PACKAGECONFIG ??= ""
>> +
>> +PACKAGECONFIG[tist] = "--enable-tist,,"
> would you mind to convert wifi, bluetooth and 3g also to PACKAGECONFIGs?
>
>> +
>>   INITSCRIPT_NAME = "connman"
>>   INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
>>   
>> -- 
>> 1.8.2.1
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Something like:

PACKAGECONFIG ??= " \
${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)}\
                   "

PACKAGECONFIG[wifi] = "--enable-wifi,--disable-wifi,"


Or were you thinking of another method?

-- 

   Jack Mitchell (jack at embed.me.uk)
   Embedded Systems Engineer
   http://www.embed.me.uk

--