[OE-core] [PATCH] image.bbclass: Don't mark do_rootfs and do_build as nostamp
Paul Eggleton
paul.eggleton at linux.intel.com
Sat Apr 27 08:34:19 UTC 2013
On Friday 26 April 2013 12:30:38 Phil Blundell wrote:
> There doesn't appear to be any compelling reason for these tasks to be
> nostamp and having them re-run on every build can be irritating (for
> example, when the image is an initramfs which your kernel image depends
> on).
>
> Signed-off-by: Phil Blundell <philb at gnu.org>
> ---
> meta/classes/image.bbclass | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index ffb372a..667d03d 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -168,11 +168,9 @@ LINGUAS_INSTALL ?= "${@" ".join(map(lambda s:
> "locale-base-%s" % s, d.getVar('IM
>
> PSEUDO_PASSWD = "${IMAGE_ROOTFS}"
>
> -do_rootfs[nostamp] = "1"
> do_rootfs[dirs] = "${TOPDIR} ${WORKDIR}/intercept_scripts"
> do_rootfs[lockfiles] += "${IMAGE_ROOTFS}.lock"
> do_rootfs[cleandirs] += "${S} ${WORKDIR}/intercept_scripts"
> -do_build[nostamp] = "1"
>
> # Must call real_do_rootfs() from inside here, rather than as a separate
> # task, so that we have a single fakeroot context for the whole process.
I have to say I'm not in favour of this. AFAIK these tasks have always been
nostamp, and I'm not sure making do_build is going to help for the case you
cite because the dependency on INITRD_IMAGE is on do_rootfs.
If you're concerned about your initramfs image rebuilding when building the
main image, what happens if you specify do_rootfs[nostamp] = "0" ?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
More information about the Openembedded-core
mailing list