[OE-core] [PATCH v3] base.bbclass: Add support to EXTRA_DISTRO_FEATURES
Otavio Salvador
otavio at ossystems.com.br
Thu Aug 1 13:45:55 UTC 2013
On Thu, Aug 1, 2013 at 10:08 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Thu, 2013-08-01 at 09:19 -0300, Otavio Salvador wrote:
>> On Thu, Aug 1, 2013 at 4:37 AM, Richard Purdie
>> <richard.purdie at linuxfoundation.org> wrote:
>> > On Wed, 2013-07-31 at 12:13 -0300, Otavio Salvador wrote:
>> ...
>> >> + # Avoid readding the removed features later
>> >> + d.delVarFlag("DISTRO_FEATURES", "_append")
>> >> + d.delVarFlag("DISTRO_FEATURES", "_prepend")
>> >
>> > I quite clearly said this was a hack to allow you to see what the
>> > problem was with the code and that it was *not* an acceptable change to
>> > go into the core. I don't see any mention of that now and that is a
>> > little frustrating to see this being proposed as a patch.
>>
>> I forgot to add it to commit log, sorry. The idea was to send the
>> working code so people using it could use a valid one. I understand we
>> need to find a better solution for this but I am clueless about where
>> to look.
>>
>> I can work in another solution if someone can tell me what needs to be
>> done. I looked at bb.data_smart code and didn't find any other way to
>> fix this.
>>
>> The finalize code would be the other place I can think about changing. Any hint?
>
> Using existing API, did you try just d.delVar("DISTRO_FEATURES") and
> then setting it again? Unlike the above, that doesn't assume any
> knowledge of bitbake internals.
Works like a charm. I will send v4 with this one.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
More information about the Openembedded-core
mailing list