[OE-core] [PATCH][V2] u-boot: state the MACHINE when skipping u-boot

Otavio Salvador otavio at ossystems.com.br
Thu Aug 1 17:17:36 UTC 2013


On Thu, Aug 1, 2013 at 2:09 PM, Laszlo Papp <lpapp at kde.org> wrote:
> On Thu, Aug 1, 2013 at 6:02 PM, Paul Eggleton
> <paul.eggleton at linux.intel.com> wrote:
>>
>> I'm afraid this is not practical. The ability to specify the value for
>> MACHINE
>> and other variables from the external environment is not just there for
>> folks
>> running bitbake manually from the command line, but also external scripts
>> as
>> well, and they could quite legitimately set it to the same value that has
>> been
>> specified in the configuration file and showing a warning in that case
>> would be
>> undesirable.
>
>
> Oh yeah, it cannot happen with compiler outputs the same way? Answer is: it
> can.
>
> You can add another feature later though if you wish to suppress warnings.
> That makes sense to me.

It makes sense to not add the warning. Too many warnings just confuse
users and does not provide anything useful as users just ignore them
in the end.

>> I'm not sure I understand the value of showing this warning in any case.
>> The
>> system is not going to do anything that the user won't expect - the user
>> specified the value of MACHINE on the command line and that's the value
>> that is
>> being used. The fact that it is the same as what's in the configuration
>> file is
>> incidental.
>
>
> Have you used gcc, clang, etc? Do you have experience with warnings in
> general? They are there in certain cases because the programmer may have or
> probably made a mistake. It is a lot easier to figure out at that time than
> debugging very hard later...

<sarcarsm>
I am sure we all in Yocto community NEVER used GCC/CLang...
</sarcarsm>

Did you EVER read your own messages? Please do.

> Actually, it is even getting more serious in your "script" case where it
> would be totally hidden by the script if it is not logging properly, and you
> would only realize an issue later.
>
> Surely, we all copy paste wrong on a daily basis, and we also write "foo"
> instead "fow" and "bar" at times. So, I do not follow your comment. Nothing
> to reinvent the wheel here, just follow the general practice that other
> software developers have figured out along the decades.

That's the point; we are folloing Yocto general practice and doing it
different here won't help. Just confuse.

Regards,

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list